ENH Run php parallel lint if it's installed #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Jul 1, 2024
action.yml
Outdated
| @@ -238,6 +238,10 @@ runs: | |||
| if: ${{ inputs.phplinting == 'true' }} | |||
| shell: bash | |||
| run: | | |||
| if [[ -f vendor/bin/parallel-lint ]]; then | |||
| echo "Running parallel-lint" | |||
| vendor/bin/parallel-lint --exclude=vendor --exclude=.git . | |||
There was a problem hiding this comment.
Excluding .git is just for speed - means it doesn't have to look at all the files in there checking for php files that aren't there.
2 tasks
emteknetnz
requested changes
Jul 2, 2024
action.yml
Outdated
| @@ -238,6 +238,10 @@ runs: | |||
| if: ${{ inputs.phplinting == 'true' }} | |||
| shell: bash | |||
| run: | | |||
| if [[ -f vendor/bin/parallel-lint ]]; then | |||
| echo "Running parallel-lint" | |||
| vendor/bin/parallel-lint --exclude=vendor --exclude=.git . | |||
There was a problem hiding this comment.
Suggested change
| vendor/bin/parallel-lint --exclude=vendor --exclude=.git . | |
| vendor/bin/parallel-lint --exclude vendor --exclude .git . |
I tested this locally and it seems that you do not include the equals sign
There was a problem hiding this comment.
Oh, well. That's silly of it lol.
Done.
GuySartorelli
force-pushed
the
pulls/1.1/run-parallel-lint
branch
from
75a94fc
to
8ec54a6
Compare
emteknetnz
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue